<html>
<head><meta charset="utf-8"><title>Permission to start FCP merges? · t-libs · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/index.html">t-libs</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Permission.20to.20start.20FCP.20merges.3F.html">Permission to start FCP merges?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="187715669"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Permission%20to%20start%20FCP%20merges%3F/near/187715669" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Kalbertodt <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Permission.20to.20start.20FCP.20merges.3F.html#187715669">(Feb 08 2020 at 12:45)</a>:</h4>
<p>Hi there. I am currently not included in rfcbot's t-libs list. And this is good for now, as I don't think I currently have the time for that. However, I often need to FCP merge PRs but I can't do that. See <a href="https://github.com/rust-lang/rust/pull/68099#issuecomment-579964452" target="_blank" title="https://github.com/rust-lang/rust/pull/68099#issuecomment-579964452">this attempt</a> for example, where someone needed to help me.</p>
<p>Is there a way for me to start FCP merges without being included in the "signoff list"? I would like to avoid having to ping someone else all the time. Or should I just reassign PRs requiring FCP merges to someone else?</p>



<a name="187715928"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Permission%20to%20start%20FCP%20merges%3F/near/187715928" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Permission.20to.20start.20FCP.20merges.3F.html#187715928">(Feb 08 2020 at 12:54)</a>:</h4>
<p><span class="user-mention" data-user-id="118772">@Lukas Kalbertodt</span> rfcbot's list is based on <code>rust-lang/team</code> so right now you're not marked as being on the libs team at all. You should make a PR that adds yourself to the team. <a href="https://github.com/rust-lang/team" target="_blank" title="https://github.com/rust-lang/team">https://github.com/rust-lang/team</a></p>



<a name="187715998"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Permission%20to%20start%20FCP%20merges%3F/near/187715998" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Kalbertodt <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Permission.20to.20start.20FCP.20merges.3F.html#187715998">(Feb 08 2020 at 12:56)</a>:</h4>
<p><span class="user-mention" data-user-id="219696">@XAMPPRocky</span> I am already in the libs team there: <a href="https://github.com/rust-lang/team/blob/master/teams/libs.toml" target="_blank" title="https://github.com/rust-lang/team/blob/master/teams/libs.toml">https://github.com/rust-lang/team/blob/master/teams/libs.toml</a><br>
I'm simply excluded from the rfcbot.</p>



<a name="187716002"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Permission%20to%20start%20FCP%20merges%3F/near/187716002" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Kalbertodt <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Permission.20to.20start.20FCP.20merges.3F.html#187716002">(Feb 08 2020 at 12:57)</a>:</h4>
<p>I wonder if there is a way for this hybrid.</p>



<a name="187716007"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Permission%20to%20start%20FCP%20merges%3F/near/187716007" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Kalbertodt <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Permission.20to.20start.20FCP.20merges.3F.html#187716007">(Feb 08 2020 at 12:57)</a>:</h4>
<p><span class="user-mention" data-user-id="222471">@BurntSushi</span> Can you start an FCP merge? Or is it just me who can't?</p>



<a name="187716124"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Permission%20to%20start%20FCP%20merges%3F/near/187716124" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Permission.20to.20start.20FCP.20merges.3F.html#187716124">(Feb 08 2020 at 13:01)</a>:</h4>
<p><span class="user-mention" data-user-id="118772">@Lukas Kalbertodt</span> That would feel like a weird hybrid to me. You want to be able to start a voting process, but not be a voting member is that correct?</p>



<a name="187716475"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Permission%20to%20start%20FCP%20merges%3F/near/187716475" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Permission.20to.20start.20FCP.20merges.3F.html#187716475">(Feb 08 2020 at 13:09)</a>:</h4>
<p><span class="user-mention" data-user-id="118772">@Lukas Kalbertodt</span> Is your exclusion from the rfcbot list intentional? We could just drop that exclusion...</p>



<a name="187716522"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Permission%20to%20start%20FCP%20merges%3F/near/187716522" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Permission.20to.20start.20FCP.20merges.3F.html#187716522">(Feb 08 2020 at 13:10)</a>:</h4>
<p>Looks like yes, though there's no rationale given in the PR</p>



<a name="187716838"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Permission%20to%20start%20FCP%20merges%3F/near/187716838" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Kalbertodt <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Permission.20to.20start.20FCP.20merges.3F.html#187716838">(Feb 08 2020 at 13:20)</a>:</h4>
<p>Yeah this was intentional. We discussed this on the mailing list briefly and concluded that it would be a good idea to not add me to everything at once, but start slowly. I.e. just review rotation first, but not rfcbot.</p>



<a name="187716844"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Permission%20to%20start%20FCP%20merges%3F/near/187716844" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Kalbertodt <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Permission.20to.20start.20FCP.20merges.3F.html#187716844">(Feb 08 2020 at 13:21)</a>:</h4>
<p>But I agree, it would be a weird hybrid. It's also just strange right now as part of the "review job" is to start FCP merges.</p>



<a name="187733907"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Permission%20to%20start%20FCP%20merges%3F/near/187733907" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Simon Sapin <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Permission.20to.20start.20FCP.20merges.3F.html#187733907">(Feb 08 2020 at 22:31)</a>:</h4>
<p>If you want to take this on I think it’s fine to remove the exclusion</p>



<a name="187733911"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Permission%20to%20start%20FCP%20merges%3F/near/187733911" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Simon Sapin <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Permission.20to.20start.20FCP.20merges.3F.html#187733911">(Feb 08 2020 at 22:31)</a>:</h4>
<p>At the moment rfcbot considers that proposing FCP is itself a vote in favor of that proposal</p>



<a name="187752927"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Permission%20to%20start%20FCP%20merges%3F/near/187752927" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Kalbertodt <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Permission.20to.20start.20FCP.20merges.3F.html#187752927">(Feb 09 2020 at 09:49)</a>:</h4>
<blockquote>
<p>At the moment rfcbot considers that proposing FCP is itself a vote in favor of that proposal</p>
</blockquote>
<p>That makes sense, I guess</p>



<a name="187752985"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Permission%20to%20start%20FCP%20merges%3F/near/187752985" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Kalbertodt <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Permission.20to.20start.20FCP.20merges.3F.html#187752985">(Feb 09 2020 at 09:51)</a>:</h4>
<blockquote>
<p>If you want to take this on I think it’s fine to remove the exclusion</p>
</blockquote>
<p>Unfortunately, I don't think I'm ready to take this on yet. Currently, I don't yet have the feeling I am reviewing my PRs in a timely fashion, so I first want to get that under control before taking on more tasks.</p>



<a name="188123142"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Permission%20to%20start%20FCP%20merges%3F/near/188123142" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> BurntSushi <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Permission.20to.20start.20FCP.20merges.3F.html#188123142">(Feb 13 2020 at 16:28)</a>:</h4>
<p>Ah sorry, I didn't see this. I haven't tried to start an fcp merge. Generally I don't have the bandwidth to keep up with std PRs/reviews and such. Although I'm happy to be pinged on demand. :)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>